Feature/star history charts #949
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Star History chart component under GitHub Statistics - Support multiple repositories with live preview - Add chart type selection (Date/Timeline) - Add theme selection (Light/Dark/Auto) - Include repository validation and error handling - Integrate with markdown generation - Add responsive design and accessibility features
Author
@rahuldkjain Please have a look :) |
Owner
|
exciting, lets create a PR to dev branch so that we can see the preview and test |
Author
|
@rahuldkjain Please have a look :) |
Author
|
@rahuldkjain Can you please check this... Like If any suggestion or modification needs then I do that :) |
There was a problem hiding this comment.
Pull Request Overview
This PR adds Star History chart integration to GitHub profile README generation, allowing users to showcase repository star growth trends over time.
Key Changes
- Added new Star History configuration types and validation schemas with support for multiple repositories, chart types (Date/Timeline), and theme options (light/dark/auto)
- Implemented Star History utility functions for URL generation, repository validation, and markdown generation with support for responsive theming
- Integrated Star History UI component into the Skills section with live preview, validation feedback, and configuration options
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types/profile.ts | Added StarHistoryConfig interface and fields to ProfileData for Star History feature |
| src/lib/validations.ts | Added Zod validation schema for Star History with repository format validation and default configuration |
| src/lib/star-history.ts | Implemented core Star History functionality including URL generation, validation, markdown generation, and default configuration |
| src/lib/markdown-generator.ts | Integrated Star History markdown generation into the main profile generator |
| src/components/sections/star-history.tsx | Created React component for Star History configuration with live preview, form controls, and validation |
| src/components/sections/skills-section.tsx | Added Star History component to Skills section with necessary form hooks |
| src/app/page.tsx | Updated main page to include Star History default configuration and pass required form props |
Comments suppressed due to low confidence (1)
src/components/sections/star-history.tsx:20
- Unused variable mainEnabled.
const mainEnabled = watch('starHistory');
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
@DipakHalkude please look at the copilot comments. |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
- Fix theme parameter handling in URL generation - Make auto-theme charts clickable with anchor tags - Remove duplicate default configuration - Clean up unused variables
…kHalkude/github-profile-readme-generator into feature/star-history-charts
Author
|
@rahuldkjain I've fixed all the Copilot comments. Please review the latest changes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔄 Pull Request
📋 Type of Change (check all applicable)
📖 Description
What changed?
Why was this change made?
How does this change help users?
🔗 Related Issues
🧪 Testing & Quality Assurance
Testing Done (check all applicable)
Test Instructions
Expected Behavior
📸 Screenshots/Recordings
Before
After
📋 Checklist
Code Quality
npm run type-check)npm run lint)npm run format)npm run build)Accessibility
Mobile & Responsive
Browser Compatibility
Documentation
Security & Privacy
🚀 Deployment Notes
📝 Additional Notes
👀 Reviewers
By submitting this PR, I confirm that: