Raise errors to suggest completing class configuration #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the following error is raised when executing `Base.find`: ``` NoMethodError: undefined method `path' for nil ``` Similarly, `.collection_url` and `.element_url` invocations raise a similar error: ``` bad argument (expected URI object or URI string) ``` This commit improves the error messages raised when attempting to use an `ActiveResource::Base` class that hasn't yet been configured with a `.site` class attribute. The `Missing site URI` message raised as an `ArgumentError` mirror the one raised by [ActiveResource::Connection#initialize][]. [ActiveResource::Connection#initialize]: https://github.com/rails/activeresource/blob/v6.2.0/lib/active_resource/connection.rb#L34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, incomplete class-level configuration would raise errors unrelated to the missing values.
For example, the following error is raised when executing
.findwithout first setting.siteon the resource class:Similarly,
.collection_urland.element_urlinvocations raise a similar error:This commit improves the error messages raised when attempting to use an
ActiveResource::Basesubclass that hasn't yet been configured with a.siteclass attribute.The
Missing site URImessage raised as anArgumentErrormirror the one raised by ActiveResource::Connection#initialize.