Prefix: restore variable for the sake of error logging #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve a 13 year old bug (according to a [comment on 7589c1a][]) by re-declaring the `code` variable that was unintentionally removed in [da74c4f][]. Prior to this commit, the following error is raised when setting `.prefix = nil`: ``` NameError: undefined local variable or method `code' for class Person ``` However, the error should be a `NoMethodError` from calling `String#gsub` on `nil`, rather than the `NameError` raised by the missing variable. The `NoMethodError` can still be improved upon, but this commit aims to restore the logging visibility first-and-foremost. [comment on 7589c1a]: rails@7589c1a#r2381147 [da74c4f]: rails@da74c4f#diff-5d3e28bbfdc782e5e5501903dd1171cc83b1aef685cc5b0547f527ec2573f989R58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve a 13 year old bug (according to a comment on 7589c1a) by re-declaring the
codevariable that was unintentionally removed in da74c4f.Prior to this commit, the following error is raised when setting
.prefix = nil:However, the error should be a
NoMethodErrorfrom callingString#gsubonnil, rather than theNameErrorraised by the missing variable. TheNoMethodErrorcan still be improved upon, but this commit aims to restore the logging visibility first-and-foremost.