-
Notifications
You must be signed in to change notification settings - Fork 21.9k
[RF-DOCS] Sign up guide #55254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RF-DOCS] Sign up guide #55254
Conversation
Co-authored-by: Amanda Perino <[email protected]>
Co-authored-by: Amanda Perino <[email protected]>
Co-authored-by: Amanda Perino <[email protected]>
@excid3 how does one get to this guide? Is it linked from the Getting Started one? |
@MatheusRich @excid3 It needs to be added to: |
There are design changes coming so it will be done in a separate PR. |
@MatheusRich @p8 Just like the /docs landing page we launched last year, we are building a Tutorial landing page where all of the tutorials, and all upcoming tutorials will live. (PR here.) |
@AmandaPerino amazing! For anyone reviewing and wants to preview the results:
![]()
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great tutorial, as always @excid3! So easy to follow and yet very comprehensive! I love how clean the code is and all the little details you put here and there. It shows your deep understanding of the Rails-way. It teaches so much more than the title says. Well done!
@AmandaPerino That looks great! |
Co-authored-by: Hartley McGuire <[email protected]> Co-authored-by: Matheus Richard <[email protected]>
I can't imagine someone reading the "Getting Started" guide from Rails version 6.0. The use case for the "Getting Started" guide is a bit different than other guides. Most would probably read it once to build an app and never look at it again, whereas the other guides are used to look up things more often. The guides for older Rails version are useful when you are working on an application with that same version. So maybe it's a good idea to move that guide to /website as well? There are some existing guides which are more tutorial like. For example the plugins guide: https://guides.rubyonrails.org/plugins.html. I'm not sure those should be moved as well. |
Co-authored-by: Kyoungwon Lee (Stark) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really great guide! Despite using Rails for years, I learned a few interesting things.
What do you think about inserting tests throughout the guide, after introducing new requirements and before showing code blocks? This could help foster a TDD/test-first culture among readers.
@MatheusRich I am trying to do just that, |
@MichaelGame-Dev the page has changed a little since i've last saw this, but you can find the docs link in the Annotations section: ![]() Click on Guides and add |
Co-authored-by: Jeremy BERTRAND <[email protected]>
@excid3 Before this gets merged, could you wrap to 80 columns? |
@p8 done! |
* main: (299 commits) (docs): Fix wrong output of variable in Action View Helpers guide Add credentials:fetch command Remove `ActiveJob::ConfiguredJob#perform_all_later` method Fix typo in Sign Up and Settings Guide Fix outdated api.rubyonrails.org links in Testing Guide [ci skip] Fix outdated link in error message about missing MIME type Fix ActiveSupport::Rescuable not to be coupled with ActionController Allow to use either `:unprocessable_entity` or `:unprocessable_content` Handle Rack 3.2 `unprocessable_{entity,content}` Log when rescue_from handles an exception Fix tutorials link [RF-DOCS] Sign up guide (rails#55254) Fix typo in Actionpack Changelog Allow hosts redirects from `hosts` Rails configuration Refactor HashWithIndifferentAccess not to rely on tap as much Fix `HWIA#transform_keys!` removing defaults rate_limit notification instrumentation to include more payload Clarification about instance-level methods defined by cattr_accessor [Fix rails#55379] Default branch in github ci templates Add `relative_time_in_words` helper to ActionView ...
Motivation / Background
This is a continuation of the Getting Started guide.
Detail
After building the e-commerce store, this guide adds:
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
cc @AmandaPerino