fix: swapped Max/Min for timing fields - #342
Open
farron65 wants to merge 1 commit into
Open
Conversation
sort.Float64s sorts ascending, so index 0 is the min and index len-1 is the max. The snapshot() assignments in report.go had ConnMax/DnsMax/ReqMax/DelayMax/ResMax reading from index 0 (the min) and their Min counterparts reading from index len-1 (the max). Fixing the assignment alone would have broken the CLI output, since print.go's Details template prints these fields under the header (average, fastest, slowest) and relied on the old (backwards) values landing in the right position by coincidence. Swapped the corresponding variables in the template so both files now agree. Verified before/after with: hey -n 50 -c 5 -disable-keepalive <url> fastest/slowest columns are now correctly ordered after the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sort.Float64s sorts ascending, so index 0 is the min and index len-1 is the max. The snapshot() assignments in report.go had ConnMax/DnsMax/ReqMax/DelayMax/ResMax reading from index 0 (the min) and their Min counterparts reading from index len-1 (the max).
Fixing the assignment alone would have broken the CLI output, since print.go's Details template prints these fields under the header (average, fastest, slowest) and relied on the old (backwards) values landing in the right position by coincidence. Swapped the corresponding variables in the template so both files now agree.
Verified before/after with:
hey -n 50 -c 5 -disable-keepalive
fastest/slowest columns are now correctly ordered after the fix.