[PHP] Fix UDP sockets for PHP v8 #787
Open
+38
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So in my last PR #786 I fixed UDP channels for PHP 5.3.29 by prioritizing using sockets instead of streams. This then broke things on PHP v8 where sockets are not resources and thus treating them in the same way was causing a whole bunch of issues. This resolves those issues so the socket tests that are intended to pass do pass with both PHP v8.4 on Linux and PHP v5.3 on Winows.
At this point in time, this is a "successful" pass of the socket channel tests:
Server channels fail because there's no TCP server channel support (see rapid7/metasploit-framework#20748) and the UDP peer addres is a rex socket issue.