Port all conda recipes to rattler-build & use strict channel priority
#864
Conversation
gforsyth
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
3 similar comments
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test 7ab3a96 |
|
/ok to test |
|
We discussed this again at the cuCIM meeting this week, but didn't see an obvious cause for the test failures Diffing the changes relative to a recent passing PR ( #867 ) didn't provide any obvious clues Tried updating this PR and opening a fresh testing PR ( #868 ). The latter passed whereas this still failed Am starting wondering if there is something unique to the changes in this PR, which lead to the CI failures we see. Still not sure exactly what change causes it though |
jakirkham
changed the title
rattler-buildrattler-build & use strict channel priority
Ok, thanks for looking into that @jakirkham ! I'll start combing through the recipe with a fine-toothed comb |
|
/ok to test |
|
/ok to test |
| - SCCACHE_S3_KEY_PREFIX=libcucim-aarch64 # [aarch64] | ||
| - SCCACHE_S3_KEY_PREFIX=libcucim-linux64 # [linux64] |
There was a problem hiding this comment.
Previously we set the SCCACHE_S3_KEY_PREFIX like so
Note: The same is true of the cucim recipe
| SCCACHE_REGION: ${{ env.get("SCCACHE_REGION") }} | ||
| SCCACHE_S3_USE_SSL: ${{ env.get("SCCACHE_S3_USE_SSL") }} | ||
| SCCACHE_S3_NO_CREDENTIALS: ${{ env.get("SCCACHE_S3_NO_CREDENTIALS") }} | ||
| SCCACHE_S3_KEY_PREFIX: libcucim/${{ env.get("RAPIDS_CONDA_ARCH") }}/cuda${{ cuda_major }} |
There was a problem hiding this comment.
However it now looks like SCCACHE_S3_KEY_PREFIX is set differently?
Note: The same is true of the cucim recipe
There was a problem hiding this comment.
Hey @jakirkham ! Yeah, this was a deliberate change in all of the rattler ports to have slightly more convenient access patterns in the cache bucket.
| - CMAKE_CUDA_COMPILER_LAUNCHER | ||
| - CMAKE_CXX_COMPILER_LAUNCHER | ||
| - CMAKE_GENERATOR | ||
| - PARALLEL_LEVEL |
There was a problem hiding this comment.
Also should we still set PARALLEL_LEVEL?
Looks like it was dropped from the new recipe
There was a problem hiding this comment.
Hmm, let me check.
|
When you have a moment Gil, could you please resolve the conflicts here? |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
Have moved this to 25.10 |
This is the last project in RAPIDS that hasn't converted its conda builds from `conda-build` to `rattler-build`. That's happening in #864, but that PR isn't yet close to passing. In rapidsai/gha-tools#145, I'm working on reducing complexity in `gha-tools` by removing unused tools. This repo is the last RAPIDS project using `rapids-configure-conda-channels`, and that usage won't be removed until #864 is complete. To unblock that cleanup in `gha-tools`, this PR proposes checking in a copy of `rapids-configure-conda-channels` in this repo. That'll allow the work in `gha-tools` to proceed without being blocked by `cucim`'s migration to `rattler-build`. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Gil Forsyth (https://github.com/gforsyth) URL: #923
|
Adding a note that #923 should be reverted on this branch whenever this PR is revived. |
I've gone ahead and made this change to this PR It would be good to make sure this PR doesn't fall too far behind. We would like to merge it once it passes |
jakirkham
force-pushed
the
rattler-build
branch
from
6242fc7 to
2d5615e
Compare
jakirkham
force-pushed
the
rattler-build
branch
from
2d5615e to
8412581
Compare
|
/ok to test |
|
/ok to test |
Port all condabuild recipes over to use
rattler-buildinstead.Contributes to rapidsai/build-planning#47