Skip to content

Separate more cuda code #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 14, 2025
Merged

Conversation

RAMitchell
Copy link
Contributor

No description provided.

Signed-off-by: Rory Mitchell <[email protected]>
Signed-off-by: Rory Mitchell <[email protected]>
Signed-off-by: Rory Mitchell <[email protected]>
Signed-off-by: Rory Mitchell <[email protected]>
@RAMitchell RAMitchell marked this pull request as ready for review August 14, 2025 10:06
@RAMitchell RAMitchell requested review from seberg and Copilot August 14, 2025 10:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request separates CUDA-specific code by moving GPU implementations to dedicated .cu files, aligning with CUDA compilation requirements. The PR extracts GPU variants and CUDA-specific functions from mixed .cpp files into separate CUDA compilation units.

Key changes include:

  • Moved GPU implementations from .cpp files to new .cu files for proper CUDA compilation
  • Updated class definitions to use static member functions with forward declarations in headers
  • Removed unused variables from test files

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
cpp/tests/test_task.cpp Renamed function from get_library() to get_test_library()
cpp/tests/test_groupby_aggregation.cpp Removed unused CUDF aggregation kind variables
cpp/src/join.cu New file containing GPU variant and CUDA-specific join functions
cpp/src/join.cpp Removed GPU variant and CUDA includes, kept CPU implementation
cpp/src/groupby_aggregation.cu New file containing GPU variant and CUDA-specific aggregation functions
cpp/src/groupby_aggregation.cpp Removed GPU variant and CUDA includes, kept CPU implementation
cpp/src/filling.cu New file containing GPU variant for sequence task
cpp/src/filling.cpp Removed GPU variant and CUDA includes, kept CPU implementation
cpp/include/legate_dataframe/join.hpp Added task class definition and function declarations
cpp/include/legate_dataframe/groupby_aggregation.hpp Added task class definition and removed CUDF includes
cpp/include/legate_dataframe/filling.hpp Added task class definition and updated documentation
cpp/include/legate_dataframe/csv.hpp Added CPU variant options constant

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: Rory Mitchell <[email protected]>
Copy link
Contributor

@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for including the csv CPU_VARIANT_OPTIONS fix!

@RAMitchell RAMitchell merged commit 46e33b0 into rapidsai:main Aug 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants