dispatch for e.g. nx.Graph(backend="cugraph")
#92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriknw
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
eriknw
changed the title
nx.Graph(backend="cugraph")nx.Graph(backend="cugraph")
|
networkx/networkx#7760 is now merged, so this PR is ready for review (CC @rlratzel). |
|
Looks like our CI check to ensure >0% code coverage is now failing so I'll need to look into that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes with networkx/networkx#7760 to allow e.g.
nx.Graph()ornx.Graph(backend="cugraph")to createnxcg.Graph.Graphs created in this way are networkx-compatible graphs by default. If the user is running in "strict", GPU-only mode by setting
nx.config.backends.cugraph.use_compat_graphsto False, then Cuda Graphs will be returned.Also, I removed
yesqapre-commit hook, which is unnecessary b/c this is handled by ruff via RUF100.yesqacould occasionally be a minor nuisance by removing anoqaunderstood by ruff (as was happening in earlier commits of this PR).Despite the "WIP" / "Draft" labels, this is more-or-less ready for review and is awaiting networkx/networkx#7760 (which is also ready for review).