Skip to content

Conversation

sylvainDNS
Copy link
Contributor

This PR includes several fixes :

  • linters error with typescript parser
  • remove controlled components errors
  • add <MdxLink /> component to fix the deprecated use of Next <Link /> with a string child. If someone has a better workaround, feel free to tell me! 😉
  • optimize lockfile with yarn-deduplicate

@vercel
Copy link

vercel bot commented Oct 21, 2021

@sylvainDNS is attempting to deploy a commit to the void Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/void-team/ui-playbook/7JUHk9q7qhxWJztV9pg1RbCLZ6F5
✅ Preview: https://ui-playbook-git-fork-sylvaindns-fix-various-errors-void-team.vercel.app

Comment on lines +9 to +27
const [added, setAdded] = React.useState(false);
const [count, setCount] = React.useState(0);

React.useEffect(() => {
const id = setInterval(() => {
setAdded((prevAdded) => {
if (prevAdded === false) {
setTimeout(() => {
setCount((prevCount) => prevCount + 1);
}, 1000);
}
return !prevAdded;
});
}, 1000);
React.useEffect(() => {
const id = setInterval(() => {
setAdded((prevAdded) => {
if (prevAdded === false) {
setTimeout(() => {
setCount((prevCount) => prevCount + 1);
}, 1000);
}
return !prevAdded;
});
}, 1000);

return () => {
clearInterval(id);
};
}, []);
return () => {
clearInterval(id);
};
}, []);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the cosmical changes? Wondering why these got changed 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow response.

The problem comes from prettier configured like this :

// .prettierrc.js
useTabs: true
tabWidth: 4

I can fix it, what config do you want ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants