RDoc-3554 Deleting a non-existing compare-exchange item returns false #2164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haludi
approved these changes
Oct 30, 2025
| // If 'successful' is false - | ||
| // * The item was not deleted because the index didn't match (it was modified by someone else), | ||
| // * Or the item no longer existed at the time of deletion (it was already deleted). |
There was a problem hiding this comment.
I would consider that the same as "the index didn't match," since the index of a non-existent entry is 0.
But it's not important, it's good to be explicit about it, like you did.
You can consider adding here that distinguishing between a case where the compare-exchange exists with a different index and a case where the compare-exchange does not exist can be determined by the returned object.
If the compare-exchange does not exist, this will be null.
haludi
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
https://issues.hibernatingrhinos.com/issue/RDoc-3554/Deleting-a-non-existing-compare-exchange-item-returns-false