[Bug] Fix health probes to use custom ports from rayStartParams #4041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiniSho
requested review from
kevin85421,
andrewsykim,
rueian and
MortalHappiness
as code owners
|
@kevin85421 PTAL~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What this PR does / why we need it:
This PR fixes an issue where the liveness and readiness probes in Ray pods were hardcoded to use default ports, ignoring custom port configurations specified in
rayStartParams. This caused probe failures when users customized ports likedashboard-portordashboard-agent-listen-port.Which issue(s) this PR fixes:
Fixes health probe failures when custom ports are configured in rayStartParams.
Special notes for your reviewer:
The fix extracts port values from
rayStartParamswith fallback to default values, ensuring probes use the correct ports that Ray processes are actually listening on.