Converters - #15
Merged
Merged
Conversation
* Move again `ensure_units()` to the `converters` module * Add a deferred version of `ensure_units()` * Deprecate `to_units()` in favour of `ensure_units()` * Deprecate `util.ensure_units()` in favour of `converters.ensure_units()` * Add `to_quantity()` converter
leroyvn
force-pushed
the
converters
branch
2 times, most recently
from
November 2, 2025 23:28
9ed1343 to
7952295
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR polishes converters. Changes are as follows:
ensure_units()converter is cleaned up and extended with a deferred version that allows using it as a functor. It is relocated to theconvertersmodule. Theutil.ensure_units()alias is kept for compatibility.to_units()converter is deprecated in favour ofensure_units().to_quantity()converter is added and allows converting dicts and DataArrays to Pint quantities.