Skip to content

feat: Use e.key to determine the direction of the key #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Use e.key to determine the direction of the key #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

lint-staged
npm run lint-staged
7 changes: 3 additions & 4 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import * as React from 'react';
import classNames from 'classnames';
import useMergedState from 'rc-util/lib/hooks/useMergedState';
import KeyCode from 'rc-util/lib/KeyCode';
import * as React from 'react';

export type SwitchChangeEventHandler = (
checked: boolean,
Expand Down Expand Up @@ -66,9 +65,9 @@ const Switch = React.forwardRef<HTMLButtonElement, SwitchProps>(
}

function onInternalKeyDown(e: React.KeyboardEvent<HTMLButtonElement>) {
if (e.which === KeyCode.LEFT) {
if (e.key === 'ArrowLeft') {
triggerChange(false, e);
} else if (e.which === KeyCode.RIGHT) {
} else if (e.key === 'ArrowRight') {
triggerChange(true, e);
}
onKeyDown?.(e);
Expand Down