Fix (zod) : error paths in complex unions #787 #819
Merged
+7
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paradis-f
changed the title
|
@jorisre Could you have a look at this please ? thank you :) |
jorisre
approved these changes
Nov 6, 2025
|
@bluebill1049 The publish failed because of Node.js version requirements, as you can see in the GitHub Actions on master. Could you take a look? I can’t from the GitHub app, and I don’t have a computer right now. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #787
Solution proposed by https://github.com/Tekpakma in the issue works well. Error paths are now properly returned for unions in the zod resolver.
Also fixes type errors, there was unnecessary type assertions for errors when success is returned. (See previous commits failed builds)
Thanks for your consideration :)