RFC: New APIs to customise the DevMenu #925
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvenene
reviewed
Aug 12, 2025
cortinico
reviewed
Aug 13, 2025
| ```kotlin | ||
| data class DevMenuConfiguration( | ||
| val isDevMenuEnabled: Boolean = BuildConfig.DEBUG, | ||
| val minNumberOfShakes: Int = 2, |
There was a problem hiding this comment.
how are we handling the 'disabled' state here?
There was a problem hiding this comment.
Potentially renaming this to isShakeGestureEnabled would make for a better API that is similar between Android & iOS
There was a problem hiding this comment.
how are we handling the 'disabled' state here?
Not explicitly, though it could be effectively disabled by setting a large number.
Potentially renaming this to isShakeGestureEnabled would make for a better API that is similar between Android & iOS
I agree, I updated the proposal with that change.
Co-authored-by: Nicola Corti <[email protected]>
Co-authored-by: Nicola Corti <[email protected]>
Co-authored-by: Nicola Corti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposes new APIs that would allow frameworks to customize the DevMenu.
View the rendered RFC