-
Notifications
You must be signed in to change notification settings - Fork 151
dockerfile buildable on arm64 and other versions of ubuntu #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
qq: probably to @cortinico what should be done to make an new docker hub release? |
Hey @jabbas The failure is:
Could you please look into it? Otherwise I would have to revert it to use |
Revert it for now. I'll take a look. |
…53732) Summary: This temporarly unblocks `run_fantom_tests` till we find a solution for the docker image bump. See: - react-native-community/docker-android#242 (comment) ## Changelog: [INTERNAL] - Pull Request resolved: #53732 Test Plan: CI Reviewed By: cipolleschi Differential Revision: D82212022 Pulled By: cortinico fbshipit-source-id: 652926addf12cc2d88ac2139d3ec58a266ced9ef
@cortinico Tne C++ standard in ubuntu 24.04 is C++18 i think that code of react native or tests needs to be tweaked. |
On second look - we can install gcc-11 instead of default gcc-13, i don't think we need libc++1-11 or libc++1-18 package. The gcc-11 contains all what is needed to build c++ code. the libc++1-11/-18 is part of llvm which is an alternative c++ compiler which we don't use. |
@cortinico please check #244 |
Thanks for the quick follow up 🙏 |
…53732) Summary: This temporarly unblocks `run_fantom_tests` till we find a solution for the docker image bump. See: - react-native-community/docker-android#242 (comment) ## Changelog: [INTERNAL] - Pull Request resolved: #53732 Test Plan: CI Reviewed By: cipolleschi Differential Revision: D82212022 Pulled By: cortinico fbshipit-source-id: 652926addf12cc2d88ac2139d3ec58a266ced9ef
Hey @jabbas I sadly had to revert this on main and publish https://github.com/react-native-community/docker-android/releases/tag/v20.0 without those changes. Sadly #244 didn't fix the problem we had with I now added a new test on this repository that attempts to build |
Removal od JAVA_HOME - ubuntu itself (using update-alternatives) is setting that variable.
Change from libc++1-11 into libc++1 - the -11 version forces to use specific version of C++ flavor, without that it takes the version that is currently installed in the system.
I've tested this image by using it to build one of our applications - all went well.