feat: Implement modal tab behavior according to current APG recommendati… #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyletsang
approved these changes
Aug 2, 2025
src/useFocusTrap.tsx
Outdated
| }); | ||
|
|
||
| function handleFocus(event: FocusEvent) { | ||
| console.log('handleFocus', event.target); |
jquense
force-pushed
the
jq/modal-focus-fix
branch
from
fb5d2dc to
16a0948
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: focus first tabbable element in dialog on open and loop focus when tabbing through modal components.
I am relenting on this given some additional feedback from experts that this behavior is better than the native dialog behavior. Eventually we can just switch to
dialogif it turns out that is the pattern that "wins"