Skip to content

Conversation

mickael-menu
Copy link
Member

Fixed

Navigator

  • The safe area insets strategy was adjusted to take into account changes in iOS/iPadOS 26.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the safe area insets strategy to accommodate changes in iOS/iPadOS 26. The change replaces a custom notchAreaInsets implementation with direct use of the window's safeAreaInsets property.

Key changes:

  • Removes the custom notchAreaInsets computed property and its complex logic for handling device notches and status bars
  • Replaces all usages of notchAreaInsets with window?.safeAreaInsets across PDF and EPUB view implementations
  • Updates comments to reflect the simplified approach of using window safe area insets directly

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
UIView.swift Removes the custom notchAreaInsets computed property that handled device-specific safe area calculations
PDFDocumentView.swift Replaces notchAreaInsets usage with direct window safe area insets for content inset calculations
EPUBReflowableSpreadView.swift Updates content inset logic to use window safe area insets instead of custom notch area calculations
EPUBFixedSpreadView.swift Switches from custom notch area insets to window safe area insets for bounds calculations
CHANGELOG.md Documents the safe area insets strategy adjustment for iOS/iPadOS 26 compatibility

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mickael-menu mickael-menu merged commit 79d802a into develop Sep 30, 2025
5 checks passed
@mickael-menu mickael-menu deleted the fix/safe-area-insets branch September 30, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant