Builds: healthcheck permissions #12423
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to skip the default permsissions check here (done at `get_queryset()` method) because it filters the object by build API key and/or user access. Since we are making an anonymous request without a build API key, we need to skip this check and base it only on the `?builder=` GET attribute.
humitos
force-pushed
the
humitos/healthcheck-api-permissions
branch
from
e82ef87 to
d415010
Compare
stsewd
reviewed
Aug 19, 2025
| @@ -307,7 +308,12 @@ def concurrent(self, request, **kwargs): | |||
| methods=["post"], | |||
There was a problem hiding this comment.
You should be able to just override get_queryset here
get_queryset=lambda: Build.objects.all(),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to skip the default permsissions check here (done at
get_queryset()method) because it filters the object by build API key and/or user access.Since we are making an anonymous request without a build API key, we need to skip this check and base it only on the
?builder=GET attribute.