feat: increase player UI hide delay to 5 seconds #1755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR kinda reminds me, not sure if that is the reason for it, but my opinion is while a touch is ongoing on controls on mobile, it should not hide at all, because, especially in vertical mode, it makes sliding to the further controls when many are enabled hard as as you are sliding the controls just disappear on you. This would probably help that but its just my opinion that it would be better to just not hide it while a touch is ongoing and reser the delay during that time so that it hides from certain amount of seconds after you arent touching it at all. I'm probably explaining this very poorly though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.