-
Notifications
You must be signed in to change notification settings - Fork 694
Upgrade libraries version and gradle wrapper #1823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@C10udburst Can you take a closer look at this pull request, as I am not up to date with the build process.
// Universal build config | ||
classpath(libs.buildkonfig.gradle.plugin) | ||
// Task to list dependencies updates // https://github.com/ben-manes/gradle-versions-plugin | ||
tasks.withType<com.github.benmanes.gradle.versions.updates.DependencyUpdatesTask> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this included? Android studio already includes this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't use Android Studio and I think there are other people who don't either. But I can't remove it without any problems :)
f37a275
to
af4f626
Compare
af4f626
to
5bc9584
Compare
Why isn't this merged yet? |
There is a lot of changes, and no one else have looked at it. I do not have the extensive knowledge about the build system to merge this in good faith. |
@fire-light42 I can try to split it even further. I'll create a new pr that only modifies |
buildscript
block toplugins
settings.gradle.kts
(default for new A.S. projects)alias()
to import plugins info from version cataloglibs.versions.toml