-
Notifications
You must be signed in to change notification settings - Fork 694
Improve Gradle Configuration #1902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Use version catalog for applying gradle plugin - Removing unused entry in version catalog - Removing docs module and instead setup dokka at the root project - Bump JVM target from 1.8 to 21
- Update java version in github action
- Update github action for generate_dokka.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good code-wise, but I am unsure if this will break some github workflow like dokka. @C10udburst can you take a look at this.
LGTM |
Have the things I mentioned in #1493 been tested to not happen (like the error unknown class with library documentation)? IIRC I tried something very similar to this initially but it led to some of those issues so changed it a bit. Just want to confirm though. |
Hi @Luna712, It's not happening when I run the dokka task
And the source link work as intended source.link.mp4 |
Description
This PR include:
For documentation using dokka, I think it's unnecessary creating a module just to trigger task for documentation generation.
Now the gradle task can be triggered from the root project like this:
And the documentation will be generated here:
Validation
With this changes, the code still run as intended.
Screen.Recording.2025-09-11.at.09.13.07.mov