Skip to content

Conversation

diogob003
Copy link
Contributor

  • Group subtitles by language code instead of name
  • Show flag and localized name on chose subtitles / mirrors dialog

I'm unsure about it.
Using SubtitleHelper to translate names fix "en -> English", but may group weird names like "English / German" into "unknown".
Adding a flag here seems a bit ugly to me; maybe without the flag it would be better.

Old vs new behavior
Screenshot_20250927-002311-2

Leave your opinion

@fire-light42
Copy link
Collaborator

This pull request shares a lot of code with #1815 I am unsure which should be reviewed or merged first.

@diogob003
Copy link
Contributor Author

This pull request shares a lot of code with #1815 I am unsure which should be reviewed or merged first.

The other one. This pr is a draft and I'm waiting to see if more people support or oppose the changes because I unsure if it looks good with flag 🏳️

@diogob003 diogob003 force-pushed the flag-emoji-on-mirrors-list branch from 51e54ed to 79e3a0a Compare September 29, 2025 02:44
* Show flag and translated name when choosing subtitles / sources
* Group by language code instead of name on sources / mirrors selection
@diogob003 diogob003 force-pushed the flag-emoji-on-mirrors-list branch from 79e3a0a to 231d067 Compare September 29, 2025 02:59
@jeyjai
Copy link

jeyjai commented Sep 29, 2025

Hey, got told to comment here about a subtitle issue. Extensions that have AI alternatives, often named "english (AI)", always appear above normal english, which results in cloudstream automatically picking the AI alternative if you have subtitles enabled, and you have to manually switch on every single episode.

So it would be nice if you could change the sorting to have the original language first, and probably even when there's mutliple numbered alternatives, and anything inside parentheses after normal numbering. Could probably even prioritize a space and lettering beneath a space and numbering as well so if a subtitle is titled "english" or "english 1", they would still be picked before anything titled "english (AI)" or "english AI"

If you're looking for something to test it I'd recommend streamplay-anime, they have AI on pretty much all shows that have english dubs

@rockhero1234
Copy link
Contributor

This pull request shares a lot of code with #1815 I am unsure which should be reviewed or merged first.

The other one. This pr is a draft and I'm waiting to see if more people support or oppose the changes because I unsure if it looks good with flag 🏳️

I also feel flags looks weird there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants