-
Notifications
You must be signed in to change notification settings - Fork 35
feat: include a short summary of the blog post. #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Since the post's `content` field is already populated with the contents of a `summary` tag (as far as I can see), this commit hooks that data into the message posted to Zulip.
also, remove the dependency on `textwrap`. adds a usage description of the feature to the README and an entry to CHANGES.md
|
just wanted to re-up the ask for suggestions on how to test this change :) |
|
Nice! Re: testing, have you checked out the directions linked from the README yet? I don’t know if they’re up to date, but seems like a good place to start |
|
i'm a little stuck on the dev directions (notably Docker and Postgres are both new to me, so probably the error is small but tough for me to see). i've installed |
|
I was able to test this, thanks to @jdkaplan :). I think he'll PR the dev environment fix that got me unblocked. There's a problem: For example, I added Maddie's blog and this is the message that my local version of Blaggregator produced:
|
|
idea: maybe an easier place to intervene is at crawl time? see Since this change would only affect new entries (and I don't think that post.content is used anywhere else at all, but you should fact-check that) then there's no need to handle retroactive entries, only new ones. (this idea is based on 5 min of flipping through the codebase and my dusty memories of my initial work on the project, but I haven't been closely following changes since, nor have I set it up to run locally, so please vet the idea before using it!) |
Use markdownify in feedergrabber27.py to convert HTML summaries to markdown ones.
|
thanks for the suggestion @sursh! I think that got me in the right direction; here's a new test with Maddie's blog:
and
both of these seem much better equipped to be Zulip messages :) |
Since the post's
contentfield is already populated with the contents of asummarytag (as far as I can see), this commit hooks that data into the message posted to Zulip.i'd love guidance on how to test my changes! i was able to build the docker image, but running it appears to just drop me into a Python REPL.