Custom Kube State Metrics: Increase Resources - #13553
Conversation
Kustomize Render DiffComparing
Total: 3 components, +6 -6 lines 📋 Full diff available in the workflow summary and as a downloadable artifact. |
PR Summary by QodoIncrease custom kube-state-metrics CPU requests/limits to reduce throttling
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can route each action level your way: inline, summary, both, or drop Previous review resultsReview updated until commit 3b65d33 Results up to commit e90d741
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: martysp21, pumahaka The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
@martysp21 Can you share some evidence of the CPU throttling occuring? |
Heya, I am not stating that any throttling is happening at the moment. This is a prevention and minimal recommended resource allocation taken from the official docs of KSM. https://github.com/kubernetes/kube-state-metrics#resource-recommendation |
raks-tt
left a comment
There was a problem hiding this comment.
/hold
Requesting for JIRA/ references why this is being done
The change is made to adhere for latest resource recommendation stated in the KSM docs. This change was not triggered by any other problem than prevention.
e90d741 to
3b65d33
Compare
|
Code review by qodo was updated up to the latest commit 3b65d33 |
|
/unhold |
|
/lgtm |
🤖 Pipeline Failure AnalysisCategory: Configuration The pipeline failed during Konflux installation because the ArgoCD application 'vector-kubearchive-log-collector-in-cluster-local' remained in an 'Unknown' state, blocking component synchronization. 📋 Technical DetailsImmediate CauseThe ArgoCD application 'vector-kubearchive-log-collector-in-cluster-local' failed to deploy or reach a healthy state during the Contributing FactorsNo specific contributing factors were identified from the provided build logs or the supplemental diagnostic artifacts. The application's 'Unknown' state without a clear error message suggests a potential internal misconfiguration or an underlying environmental issue that was not captured in the available logs. ImpactThe inability of the 🔍 Evidenceappstudio-e2e-tests/konflux-ci-install-konfluxCategory: Logs:
|
|
/unhold |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13553 +/- ##
=======================================
Coverage 60.38% 60.38%
=======================================
Files 24 24
Lines 1628 1628
=======================================
Hits 983 983
Misses 563 563
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Production Approval Record
|
|
❗ Detected an outage of the following critical component(s)❗
Due to this issue E2E tests will probably fail. Please keep an eye on the following status pages: and add a comment |
|
@martysp21 this PR was approved for production 3d ago but is still open. Its required CI checks aren't passing yet. Once that's resolved it should merge; close the PR if it's no longer needed. |
|
/retest |
56ffc4d
into
redhat-appstudio:main
Increase the CPU allocation to prevent CPU throttling and memory spikes.
The change is made to adhere for latest resource recommendation stated
in the KSM docs. This change was not triggered by any other problem than
prevention.
https://github.com/kubernetes/kube-state-metrics#resource-recommendation