KFLUXVNGD-1283: enable Cargo config.json subFilters on production (ring-2, ring-3) - #13753
Conversation
Kustomize Render DiffComparing
Total: 6 components, +205 -205 lines 📋 Full diff available in the workflow summary and as a downloadable artifact. |
PR Summary by QodoEnable Cargo config rewrites across production Squid rings 2–3
AI Description
Diagram
High-Level Assessment
Files changed (6)
|
Code Review by Qodo
1. Ring-2 and ring-3 combined
|
…ngs 2-3) Promote ring-1-validated nginx subFilters for cargo-proxy config.json to remaining production squid overlays. Bump caching-helm to 0.1.1889+ca96506. Clusters: stone-prod-p02, kflux-rhel-p01, kflux-ocp-p01, stone-prd-rh01, kflux-prd-rh02, kflux-prd-rh03 ## Validation - Staging: redhat-appstudio#13561, redhat-appstudio#13657 - Ring-1 production: redhat-appstudio#13702 (merged) - subFilters block matches ring-1 overlays for all six clusters in this PR ## Risk Assessment **Risk Level:** Medium **Description:** Production rollout of cargo-proxy config.json rewrites (auth-required + Nexus URL -> cluster proxy) to the remaining six prod squid clusters after ring-1 soak. Misconfiguration could break Cargo builds on those clusters. **Rollback:** Revert this PR to restore chart 0.1.1775+d865e45 and remove subFilters on the six overlays in this PR. Assisted-by: Cursor Co-authored-by: Cursor <cursoragent@cursor.com>
5e9f72f to
072d2c9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13753 +/- ##
=======================================
Coverage 60.38% 60.38%
=======================================
Files 24 24
Lines 1628 1628
=======================================
Hits 983 983
Misses 563 563
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisstea, kelchen123 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![qodo-for-redhat-appstudio[bot]](https://avatars.githubusercontent.com/u/89927105?s=60&v=4){kind=small}
| subFilters: | ||
| - location: '^/repository/cargo-proxy/config\.json$' |
There was a problem hiding this comment.
1. Ring-2 and ring-3 combined 📘 Rule violation ☼ Reliability
The rollout adds the same production Cargo subfilters to documented ring-2 and ring-3 clusters in one PR. This bypasses the required ring-by-ring isolation and increases the blast radius of a faulty rewrite.
Agent Prompt
## Issue description
This PR deploys the Cargo subfilters to production ring 2 and ring 3 simultaneously, contrary to the required ring-scoped rollout process.
## Issue Context
Keep one ring in this PR and promote the other ring through a separate PR or explicitly gated deployment stage after validation.
## Fix Focus Areas
- components/squid/production/kflux-ocp-p01/caching-helm-generator.yaml[7-40]
- components/squid/production/kflux-prd-rh02/caching-helm-generator.yaml[7-40]
- components/squid/production/kflux-prd-rh03/caching-helm-generator.yaml[7-40]
- components/squid/production/kflux-rhel-p01/caching-helm-generator.yaml[7-40]
- components/squid/production/stone-prd-rh01/caching-helm-generator.yaml[7-40]
- components/squid/production/stone-prod-p02/caching-helm-generator.yaml[7-40]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
Code review by qodo was updated up to the latest commit 072d2c9 |
Production Approval Record
Approved |
8b786e2
into
redhat-appstudio:main
3 participants
Promote ring-1-validated nginx subFilters for cargo-proxy config.json to
remaining production squid overlays. Bump caching-helm to 0.1.1889+ca96506.
Clusters: stone-prod-p02, kflux-rhel-p01, kflux-ocp-p01, stone-prd-rh01,
kflux-prd-rh02, kflux-prd-rh03
Validation
Risk Assessment
Risk Level: Medium
Description: Production rollout of cargo-proxy config.json rewrites (auth-required
ring-1 soak. Misconfiguration could break Cargo builds on those clusters.
Rollback: Revert this PR to restore chart 0.1.1775+d865e45 and remove
subFilters on the six overlays in this PR.
Assisted-by: Cursor