RHDHBUGS-2067 - Grouped optional configurations in one example file #1442

themr0c · 2025-10-14T12:42:01Z

Grouped optional configurations in one example file.
For clarity and maintainability, use snippets rather than ifeval.
Fixed include list items see https://docs.asciidoctor.org/asciidoc/latest/directives/include-list-item-content/

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s): 1.8

Issue: https://issues.redhat.com/browse/RHDHBUGS-2067

Preview:

rhdh-bot · 2025-10-14T12:56:54Z

Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1442/ @ 10/17/25 08:45:05

Signed-off-by: Fabrice Flore-Thébault <[email protected]>

Co-authored-by: Jana Vrbkova <[email protected]> Signed-off-by: Fabrice Flore-Thébault <[email protected]>

themr0c · 2025-10-15T17:10:12Z

Thank you @deerskindoll for the excellent suggestions. They led to substantial changes. Ready for a nitpick session for leftovers?

JessicaJHee

Thank for your work on this :) a few questions:

I'm not sure if there's something buggy with the preview, but the indentation of some sections doesn't seem right and some variables are not loaded as expected. PTAL
For the Provisioning your custom Red Hat Developer Hub configuration section, why do we need to include GitHub integration/ catalog provider? I don't think this is absolutely necessary just to get RHDH running initially?

...n/proc-enabling-user-authentication-with-github-as-an-auxiliary-authentication-provider.adoc

…github-as-an-auxiliary-authentication-provider.adoc Co-authored-by: Jessica He <[email protected]>

...n/proc-enabling-user-authentication-with-github-as-an-auxiliary-authentication-provider.adoc

modules/authentication/snip-enabling-user-authentication-with-github-common-first-steps.adoc

...on/snip-enabling-user-authentication-with-github-optional-authentication-provider-steps.adoc

...cation/snip-enabling-user-authentication-with-rhbk-common-authentication-provider-steps.adoc

...tion/snip-enabling-user-authentication-with-rhbk-optional-authentication-provider-steps.adoc

Co-authored-by: Jana Vrbkova <[email protected]>

…github-common-first-steps.adoc

Signed-off-by: Fabrice Flore-Thébault <[email protected]>

themr0c · 2025-10-17T08:43:27Z

@JessicaJHee

Where precisely is the identation wrong? I could not find it.
Provisioning your custom Red Hat Developer Hub configuration section fixed.

deerskindoll

lgtm

…edhat-developer#1442) * RHDHBUGS-2067 - Grouped optional configurations in one example file Signed-off-by: Fabrice Flore-Thébault <[email protected]> * Apply suggestions from code review Co-authored-by: Jana Vrbkova <[email protected]> Signed-off-by: Fabrice Flore-Thébault <[email protected]> * Update modules/authentication/proc-enabling-user-authentication-with-github-as-an-auxiliary-authentication-provider.adoc Co-authored-by: Jessica He <[email protected]> * Apply suggestions from code review Co-authored-by: Jana Vrbkova <[email protected]> * Update modules/authentication/snip-enabling-user-authentication-with-github-common-first-steps.adoc * Update modules/authentication/snip-enabling-user-authentication-with-github-common-first-steps.adoc * Apply suggestions from code review Signed-off-by: Fabrice Flore-Thébault <[email protected]> --------- Signed-off-by: Fabrice Flore-Thébault <[email protected]> Co-authored-by: Jana Vrbkova <[email protected]> Co-authored-by: Jessica He <[email protected]>

openshift-ci bot added the do-not-merge/work-in-progress label Oct 14, 2025

themr0c temporarily deployed to external October 14, 2025 12:42 — with GitHub Actions Inactive

themr0c force-pushed the RHDHBUGS-2067 branch from f93273f to 83dc73e Compare October 14, 2025 12:47

themr0c temporarily deployed to external October 14, 2025 12:47 — with GitHub Actions Inactive

themr0c force-pushed the RHDHBUGS-2067 branch from 83dc73e to 1d290d3 Compare October 14, 2025 12:54

themr0c temporarily deployed to external October 14, 2025 12:54 — with GitHub Actions Inactive

themr0c force-pushed the RHDHBUGS-2067 branch from 1d290d3 to 4d39d11 Compare October 14, 2025 12:59

themr0c temporarily deployed to external October 14, 2025 12:59 — with GitHub Actions Inactive

themr0c force-pushed the RHDHBUGS-2067 branch from 4d39d11 to 2854f0f Compare October 14, 2025 14:12

themr0c temporarily deployed to external October 14, 2025 14:12 — with GitHub Actions Inactive

themr0c force-pushed the RHDHBUGS-2067 branch from 2854f0f to 289376a Compare October 14, 2025 14:13

themr0c temporarily deployed to external October 14, 2025 14:14 — with GitHub Actions Inactive

themr0c force-pushed the RHDHBUGS-2067 branch from 289376a to e5f80c4 Compare October 14, 2025 14:14

themr0c temporarily deployed to external October 14, 2025 14:14 — with GitHub Actions Inactive

themr0c force-pushed the RHDHBUGS-2067 branch from e5f80c4 to b30f272 Compare October 14, 2025 14:24

themr0c temporarily deployed to external October 14, 2025 14:25 — with GitHub Actions Inactive

themr0c force-pushed the RHDHBUGS-2067 branch from b30f272 to 308a970 Compare October 14, 2025 14:26

themr0c temporarily deployed to external October 14, 2025 14:26 — with GitHub Actions Inactive

themr0c force-pushed the RHDHBUGS-2067 branch from 308a970 to b33a7b1 Compare October 14, 2025 15:16

themr0c temporarily deployed to external October 14, 2025 15:16 — with GitHub Actions Inactive

themr0c force-pushed the RHDHBUGS-2067 branch from b33a7b1 to 1f8b0cd Compare October 14, 2025 15:17

themr0c temporarily deployed to external October 14, 2025 15:17 — with GitHub Actions Inactive

themr0c force-pushed the RHDHBUGS-2067 branch from 1f8b0cd to e345771 Compare October 14, 2025 15:31

themr0c temporarily deployed to external October 14, 2025 15:32 — with GitHub Actions Inactive

themr0c force-pushed the RHDHBUGS-2067 branch from e345771 to 0fa82bc Compare October 14, 2025 15:44

themr0c temporarily deployed to external October 14, 2025 15:44 — with GitHub Actions Inactive

themr0c force-pushed the RHDHBUGS-2067 branch from 0fa82bc to f65858a Compare October 14, 2025 15:56

themr0c temporarily deployed to external October 14, 2025 15:56 — with GitHub Actions Inactive

themr0c force-pushed the RHDHBUGS-2067 branch from f65858a to 3865de7 Compare October 14, 2025 15:57

themr0c temporarily deployed to external October 15, 2025 16:50 — with GitHub Actions Inactive

themr0c temporarily deployed to external October 15, 2025 16:53 — with GitHub Actions Inactive

themr0c force-pushed the RHDHBUGS-2067 branch from b77f8b2 to 0fe2c98 Compare October 15, 2025 17:08

themr0c temporarily deployed to external October 15, 2025 17:08 — with GitHub Actions Inactive

themr0c and others added 2 commits October 15, 2025 19:08

RHDHBUGS-2067 - Grouped optional configurations in one example file

76fae45

Signed-off-by: Fabrice Flore-Thébault <[email protected]>

Apply suggestions from code review

d8e0ef4

Co-authored-by: Jana Vrbkova <[email protected]> Signed-off-by: Fabrice Flore-Thébault <[email protected]>

themr0c force-pushed the RHDHBUGS-2067 branch from 0fe2c98 to d8e0ef4 Compare October 15, 2025 17:09

themr0c temporarily deployed to external October 15, 2025 17:09 — with GitHub Actions Inactive

JessicaJHee reviewed Oct 15, 2025

View reviewed changes

...n/proc-enabling-user-authentication-with-github-as-an-auxiliary-authentication-provider.adoc Outdated Show resolved Hide resolved

Update modules/authentication/proc-enabling-user-authentication-with-…

2d23970

…github-as-an-auxiliary-authentication-provider.adoc Co-authored-by: Jessica He <[email protected]>

themr0c temporarily deployed to external October 16, 2025 08:20 — with GitHub Actions Inactive

deerskindoll reviewed Oct 16, 2025

View reviewed changes

Apply suggestions from code review

ed7cb6a

Co-authored-by: Jana Vrbkova <[email protected]>

themr0c temporarily deployed to external October 17, 2025 08:33 — with GitHub Actions Inactive

Update modules/authentication/snip-enabling-user-authentication-with-…

a16b841

…github-common-first-steps.adoc

themr0c temporarily deployed to external October 17, 2025 08:35 — with GitHub Actions Inactive

Update modules/authentication/snip-enabling-user-authentication-with-…

dc16028

…github-common-first-steps.adoc

themr0c temporarily deployed to external October 17, 2025 08:36 — with GitHub Actions Inactive

Merge branch 'main' into RHDHBUGS-2067

afea03e

themr0c temporarily deployed to external October 17, 2025 08:37 — with GitHub Actions Inactive

Apply suggestions from code review

e15216e

Signed-off-by: Fabrice Flore-Thébault <[email protected]>

themr0c temporarily deployed to external October 17, 2025 08:42 — with GitHub Actions Inactive

themr0c added Ready to merge 💂 Peer review done 📘 and removed Technical review needed 🔩 Test all the procedures labels Oct 17, 2025

deerskindoll approved these changes Oct 17, 2025

View reviewed changes

deerskindoll merged commit 15a15a1 into redhat-developer:main Oct 17, 2025
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

RHDHBUGS-2067 - Grouped optional configurations in one example file #1442

RHDHBUGS-2067 - Grouped optional configurations in one example file #1442

Uh oh!

themr0c commented Oct 14, 2025 •

edited

Loading

Uh oh!

rhdh-bot commented Oct 14, 2025 •

edited

Loading

Uh oh!

themr0c commented Oct 15, 2025

Uh oh!

JessicaJHee left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

themr0c commented Oct 17, 2025

Uh oh!

deerskindoll left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

RHDHBUGS-2067 - Grouped optional configurations in one example file #1442

RHDHBUGS-2067 - Grouped optional configurations in one example file #1442

Uh oh!

Conversation

themr0c commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhdh-bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

themr0c commented Oct 15, 2025

Uh oh!

JessicaJHee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

themr0c commented Oct 17, 2025

Uh oh!

deerskindoll left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

themr0c commented Oct 14, 2025 •

edited

Loading

rhdh-bot commented Oct 14, 2025 •

edited

Loading