Skip to content

Conversation

jmagak
Copy link
Member

@jmagak jmagak commented Oct 15, 2025

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 15, 2025

@jmagak jmagak force-pushed the RHIDP-8632-Update-the-Bulk-Import-Plugin-to-Integrate-with-Existing-Backstage-Templates-and-Orchestrator-Workflows branch from 84a6b2b to 335d353 Compare October 15, 2025 23:25
@jmagak jmagak force-pushed the RHIDP-8632-Update-the-Bulk-Import-Plugin-to-Integrate-with-Existing-Backstage-Templates-and-Orchestrator-Workflows branch from 115f07b to 6e66f13 Compare October 16, 2025 14:59
@AndrienkoAleksandr
Copy link
Contributor

AndrienkoAleksandr commented Oct 17, 2025

Hello!
Sorry, but the file 'procedure-data-handoff-and-custom-workflow-design.adoc' gives me a strong impression that the scaffolder author is expected to handle an array of repositories inside the template.

I prepared some proposals that clarify that the bulk import feature does not pass an array of repositories to a single template run. Instead, it launches the same scaffolder template once per repository.

We already have an example of such a scaffolder template here:
https://github.com/redhat-developer/rhdh-plugins/blob/main/workspaces/bulk-import/examples/template/create-pr-with-catalog-info.yaml

(It may look a bit complex because it is designed to handle two Git providers: GitHub and GitLab.)

@jmagak jmagak force-pushed the RHIDP-8632-Update-the-Bulk-Import-Plugin-to-Integrate-with-Existing-Backstage-Templates-and-Orchestrator-Workflows branch from 974f48c to 4412885 Compare October 17, 2025 14:34
@jmagak jmagak force-pushed the RHIDP-8632-Update-the-Bulk-Import-Plugin-to-Integrate-with-Existing-Backstage-Templates-and-Orchestrator-Workflows branch from 948dd70 to a0413df Compare October 22, 2025 12:45
@jmagak
Copy link
Member Author

jmagak commented Oct 22, 2025

/cherry-pick release-1.8

@openshift-cherrypick-robot
Copy link
Contributor

@jmagak: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…Integrate-with-Existing-Backstage-Templates-and-Orchestrator-Workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Technical review done ⛅ Any procedure has been succesfully tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants