Skip to content

docs: fix export-dynamic-plugin command for exporting backend plugins #3160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

docs: fix export-dynamic-plugin command for exporting backend plugins #3160

wants to merge 4 commits into from

Conversation

@zeshanziya
Copy link
Contributor

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci
Copy link

openshift-ci bot commented Jul 18, 2025

Hi @zeshanziya. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zeshanziya zeshanziya changed the title doc: fix export-dynamic-plugin command for exporting backend plugins docs: fix export-dynamic-plugin command for exporting backend plugins Jul 18, 2025
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions bot added the Stale label Jul 26, 2025
@christoph-jerolimov
Copy link
Member

/cc @kadel @gashcrumb @davidfestal

davidfestal
davidfestal reviewed Aug 14, 2025
View reviewed changes
docs/dynamic-plugins/export-derived-package.md

```bash
npx @janus-idp/cli@latest export-dynamic-plugin --shared-package '!/@backstage/plugin-notifications/' --embed-package @backstage/plugin-notifications-backend
npx @janus-idp/cli@latest package export-dynamic-plugin --shared-package '!/@backstage/plugin-notifications/' --embed-package @backstage/plugin-notifications-backend
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kadel Shouldn't the docs be changed to use the rhdh-cli command now ?

@kadel
Copy link
Member

kadel commented Aug 18, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 18, 2025
@openshift-ci
Copy link

openshift-ci bot commented Aug 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Aug 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Aug 19, 2025
@openshift-ci
Copy link

openshift-ci bot commented Aug 19, 2025

New changes are detected. LGTM label has been removed.

@github-actions
Copy link
Contributor

The image is available at:

@kadel kadel enabled auto-merge (squash) August 20, 2025 11:40
@github-actions
Copy link
Contributor

The image is available at:

@github-actions github-actions bot removed the Stale label Aug 21, 2025
@christoph-jerolimov
Copy link
Member

/ok-to-test

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions bot added the Stale label Aug 30, 2025
@github-actions github-actions bot closed this Sep 27, 2025
auto-merge was automatically disabled September 27, 2025 02:00

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidfestal davidfestal davidfestal left review comments

@dzemanov dzemanov Awaiting requested review from dzemanov

@its-mitesh-kumar its-mitesh-kumar Awaiting requested review from its-mitesh-kumar

@gashcrumb gashcrumb Awaiting requested review from gashcrumb

@kadel kadel Awaiting requested review from kadel

Assignees

@kadel kadel

Labels

approved ok-to-test Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zeshanziya @christoph-jerolimov @kadel @davidfestal