Skip to content

Conversation

@lholmquist
Copy link
Member

@lholmquist lholmquist commented Jul 18, 2025

Description

Adding e2e tests for the licensed-users-info internal backend plugin

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci
Copy link

openshift-ci bot commented Jul 18, 2025

Hi @lholmquist. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lholmquist lholmquist force-pushed the RHIDP-7768-e2e-licensed-users-info-backend branch 2 times, most recently from cbe9d84 to c919344 Compare July 18, 2025 13:04
@lholmquist lholmquist changed the title chore(e2e): Adding e2e tests for the licensed-users-info internal backend plugin chore(e2e): adding e2e tests for the licensed-users-info internal backend plugin Jul 18, 2025
@github-actions
Copy link
Contributor

@PatAKnight
Copy link
Member

/ok-to-test

@lholmquist lholmquist force-pushed the RHIDP-7768-e2e-licensed-users-info-backend branch from c919344 to ae59017 Compare July 22, 2025 13:35
@github-actions
Copy link
Contributor

@PatAKnight
Copy link
Member

/retest

4 similar comments
@PatAKnight
Copy link
Member

/retest

@PatAKnight
Copy link
Member

/retest

@PatAKnight
Copy link
Member

/retest

@PatAKnight
Copy link
Member

/retest

Copy link
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lholmquist lholmquist force-pushed the RHIDP-7768-e2e-licensed-users-info-backend branch from 05ed68a to 3cdcd03 Compare July 29, 2025 12:35
@openshift-ci openshift-ci bot removed the lgtm label Jul 29, 2025
Copy link
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 29, 2025
@github-actions
Copy link
Contributor

@openshift-ci
Copy link

openshift-ci bot commented Jul 29, 2025

@lholmquist: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests-aks-helm-nightly c919344 link false /test e2e-tests-aks-helm-nightly
ci/prow/e2e-tests-aks-operator-nightly c919344 link false /test e2e-tests-aks-operator-nightly
ci/prow/e2e-tests-gke-operator-nightly c919344 link false /test e2e-tests-gke-operator-nightly
ci/prow/cleanup-mapt-destroy-orphaned-aks-clusters c919344 link false /test cleanup-mapt-destroy-orphaned-aks-clusters
ci/prow/e2e-tests-sealight-helm-nightly c919344 link false /test e2e-tests-sealight-helm-nightly
ci/prow/e2e-tests-gke-helm-nightly c919344 link false /test e2e-tests-gke-helm-nightly
ci/prow/e2e-tests-auth-providers-nightly c919344 link false /test e2e-tests-auth-providers-nightly
ci/prow/e2e-tests-nightly c919344 link false /test e2e-tests-nightly
ci/prow/e2e-tests-osd-gcp-operator-nightly c919344 link false /test e2e-tests-osd-gcp-operator-nightly
ci/prow/e2e-tests-osd-gcp-helm-nightly c919344 link false /test e2e-tests-osd-gcp-helm-nightly
ci/prow/e2e-tests-operator-nightly c919344 link false /test e2e-tests-operator-nightly

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lholmquist lholmquist force-pushed the RHIDP-7768-e2e-licensed-users-info-backend branch from 3cdcd03 to 85215fa Compare July 29, 2025 16:37
@openshift-ci openshift-ci bot removed the lgtm label Jul 29, 2025
@PatAKnight
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 29, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jul 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PatAKnight

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 279351f into redhat-developer:main Jul 29, 2025
12 checks passed
@lholmquist lholmquist deleted the RHIDP-7768-e2e-licensed-users-info-backend branch July 29, 2025 17:39
chadcrum pushed a commit to chadcrum/rhdh that referenced this pull request Aug 3, 2025
…kend plugin (redhat-developer#3161)

* chore(e2e): adding e2e tests for the licensed-users-info internal backend plugin.

fixes: RHIDP-7768

Signed-off-by: Lucas Holmquist <[email protected]>

* squash: refactor to use the built-in playwright methods for making api requests

Signed-off-by: Lucas Holmquist <[email protected]>

* squash: make result test generic to pass when run on ci

Signed-off-by: Lucas Holmquist <[email protected]>

---------

Signed-off-by: Lucas Holmquist <[email protected]>
guyoron1 pushed a commit to guyoron1/rhdh that referenced this pull request Sep 29, 2025
…kend plugin (redhat-developer#3161)

* chore(e2e): adding e2e tests for the licensed-users-info internal backend plugin.

fixes: RHIDP-7768

Signed-off-by: Lucas Holmquist <[email protected]>

* squash: refactor to use the built-in playwright methods for making api requests

Signed-off-by: Lucas Holmquist <[email protected]>

* squash: make result test generic to pass when run on ci

Signed-off-by: Lucas Holmquist <[email protected]>

---------

Signed-off-by: Lucas Holmquist <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants