Skip to content

Conversation

debsmita1
Copy link
Member

@debsmita1 debsmita1 commented Jul 21, 2025

Description

Adds the global-floating-button config to the backstage resource

Which issue(s) does this PR fix

Screenshot 2025-07-22 at 1 15 44 PM

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci bot requested review from josephca and zdrapela July 21, 2025 15:03
@debsmita1 debsmita1 changed the title test-fab-e2e fix(fab): test-fab-e2e Jul 21, 2025
@teknaS47
Copy link
Member

/test e2e-tests

@teknaS47
Copy link
Member

/test

Copy link

openshift-ci bot commented Jul 21, 2025

@teknaS47: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test e2e-tests

The following commands are available to trigger optional jobs:

/test e2e-tests-aks-helm-nightly
/test e2e-tests-auth-providers-nightly
/test e2e-tests-gke-helm-nightly
/test e2e-tests-nightly
/test e2e-tests-operator-nightly
/test e2e-tests-osd-gcp-helm-nightly
/test e2e-tests-osd-gcp-operator-nightly

Use /test all to run the following jobs that were automatically triggered:

pull-ci-redhat-developer-rhdh-release-1.5-e2e-tests

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@teknaS47
Copy link
Member

/test e2e-tests-operator-nightly

1 similar comment
@debsmita1
Copy link
Member Author

/test e2e-tests-operator-nightly

@debsmita1
Copy link
Member Author

/test e2e-tests-operator-nightly

@debsmita1 debsmita1 changed the title fix(fab): test-fab-e2e fix(e2e): modify operator e2e tests to add the fab config Jul 22, 2025
@debsmita1
Copy link
Member Author

/test e2e-tests-operator-nightly

@debsmita1
Copy link
Member Author

/test e2e-tests

@debsmita1
Copy link
Member Author

/retest

@debsmita1
Copy link
Member Author

/test e2e-tests

2 similar comments
@debsmita1
Copy link
Member Author

/test e2e-tests

@debsmita1
Copy link
Member Author

/test e2e-tests

@debsmita1
Copy link
Member Author

/retest

@debsmita1
Copy link
Member Author

/test e2e-tests-operator-nightly

1 similar comment
@debsmita1
Copy link
Member Author

/test e2e-tests-operator-nightly

Copy link

openshift-ci bot commented Jul 24, 2025

@debsmita1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests-operator-nightly 47d9d32 link false /test e2e-tests-operator-nightly

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@debsmita1
Copy link
Member Author

@subhashkhileri The global-floating-button e2e tests have passed on operator nightly

@subhashkhileri
Copy link
Member

/lgtm
/approve

Copy link

openshift-ci bot commented Jul 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: subhashkhileri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 56be7b6 into redhat-developer:release-1.5 Jul 25, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants