chore(e2e): add e2e tests for software template versioning #3189
Conversation
|
The image is available at: |
PatAKnight
force-pushed
the
e2e-template-version
branch
2 times, most recently
from
804b4ff to
40b17ff
Compare
|
The image is available at: |
|
/retest |
PatAKnight
force-pushed
the
e2e-template-version
branch
from
40b17ff to
21bad9f
Compare
|
/retest |
PatAKnight
force-pushed
the
e2e-template-version
branch
2 times, most recently
from
826e4b7 to
f17fb6d
Compare
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
There was a problem hiding this comment.
Thanks @PatAKnight, looks great.
The annotator actions are passing on the e2e runs:
/lgtm
/approve
PatAKnight
force-pushed
the
e2e-template-version
branch
from
f17fb6d to
42b76e0
Compare
|
The image is available at: |
|
/retest |
PatAKnight
force-pushed
the
e2e-template-version
branch
from
42b76e0 to
1b121e5
Compare
|
/cherry-pick release-1.7 |
|
@PatAKnight: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrienkoAleksandr, dzemanov, gustavolira The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
PatAKnight
force-pushed
the
e2e-template-version
branch
from
1b121e5 to
6358ca4
Compare
|
New changes are detected. LGTM label has been removed. |
|
The image is available at: |
|
/retest |
PatAKnight
force-pushed
the
e2e-template-version
branch
from
6358ca4 to
40bf15b
Compare
|
The image is available at: |
PatAKnight
force-pushed
the
e2e-template-version
branch
from
40bf15b to
5765deb
Compare
|
The image is available at: |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
dzemanov
force-pushed
the
e2e-template-version
branch
from
5765deb to
4d05b3c
Compare
|
The image is available at: |
Signed-off-by: Patrick <[email protected]>
…onent Signed-off-by: Patrick <[email protected]>
Signed-off-by: Patrick <[email protected]>
Signed-off-by: Patrick <[email protected]>
dzemanov
force-pushed
the
e2e-template-version
branch
from
4d05b3c to
828f628
Compare
|
/retest |
openshift-merge-bot
bot
merged commit c0a8a45
into
redhat-developer:main
|
@PatAKnight: new pull request created: #3301 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…veloper#3189) * chore(e2e): add e2e tests for software template versioning Signed-off-by: Patrick <[email protected]> * chore(e2e): fix issue in referencing the template instead of the component Signed-off-by: Patrick <[email protected]> * chore(e2e): switch the order of the tests Signed-off-by: Patrick <[email protected]> * chore(e2e): fix failing adoption insights test Signed-off-by: Patrick <[email protected]> --------- Signed-off-by: Patrick <[email protected]>
Description
Adds tests for the recent introduction of the
backstage.io/template-versionannotation. Templates are now able to enhance entities with versioning information.Also, renames the
catalog-scaffolded-from-Linktests toscaffolder-backend-module-annotatorto better reflect the full test suite. The tests are no longer focused solely on the link and are now focus on the ability to label, annotate, and version software templates.I also updated the scaffolder template link from the Janus QE repo to the community plugins repo
Finally, fixes an issue with referencing the wrong file name for the original catalog scaffolded from link tests.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer