Skip to content

Conversation

@snjeza
Copy link
Collaborator

@snjeza snjeza commented Nov 6, 2024

Signed-off-by: Snjezana Peco <[email protected]>
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part looks fine to me. I was hesitant about informing about the error, because we don't know when it might happen, and it could be annoying, but it's better than having the UI mysteriously not come up.

@rgrunber rgrunber merged commit db41286 into redhat-developer:master Nov 19, 2024
2 checks passed
mfussenegger added a commit to mfussenegger/nvim-jdtls that referenced this pull request Jan 23, 2025
There were changes to no longer provide the `signature` within the
code-action command arguments but instead require an additional request
from the client.

See:
- eclipse-jdtls/eclipse.jdt.ls#3322
- redhat-developer/vscode-java#3845

Closes: #743
mfussenegger added a commit to mfussenegger/nvim-jdtls that referenced this pull request Jan 23, 2025
There were changes to no longer provide the `signature` within the
code-action command arguments but instead require an additional request
from the client.

See:
- eclipse-jdtls/eclipse.jdt.ls#3322
- redhat-developer/vscode-java#3845

Closes: #743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve code actions

2 participants