RI-7223 links should have underline only on hover #4789
Merged
+254
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pd-redis
requested review from
KrumTy,
pawelangelow,
dantovska,
ArtemHoruzhenko and
KIvanow
as code owners
Code Coverage - Frontend unit tests
Test suite run success4826 tests passing in 634 suites. Report generated by 🧪jest coverage report action from 4eaa0c3 |
valkirilov
previously approved these changes
Aug 1, 2025
KIvanow
previously approved these changes
Aug 1, 2025
…links-should-have-underline-only-on-hover
KIvanow
approved these changes
Aug 4, 2025
pd-redis
deleted the
fe/bugfix/RI-7223-links-should-have-underline-only-on-hover
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix links' styling - although by default in Redis-ui links are always underlined, so I would still like to see a spec for this.
In meantime also imporved styling of InlineItemEditor.tsx