-
Notifications
You must be signed in to change notification settings - Fork 270
DEV: add TCEs to HEXPIRE command page #2253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's mostly really good, but I think Augie has lost the plot a little bit, here and there. He probably just needs a couple of nudges from Doggy Daddy to sort it out :-)
| ); | ||
|
|
||
| // Set expiration on hash fields using raw Execute | ||
| RedisResult hexpireRes1 = db.Execute("HEXPIRE", "myhash", 10, "FIELDS", 2, "field1", "field2"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually implemented in the library now (HashFieldExpire(), etc) so the catchall Execute isn't necessary. I've found you sometimes need to nudge Augie in the right direction for C# because the API method names typically don't closely resemble the command names (other clients occasionally have trip-ups like this too).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't get Auggie to pony up the goods on HashFieldExpire; it insists that it doesn't exist. I give up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dwdougherty I guess you pulled the latest from the NRedisStack repo into your local clone but I think you sometimes need to do a dotnet build or whatever to update the intellisense with the latest from StackExchange.Redis (and even then, as you say, the Augster also struggles to find the non-standard method names in the repo). I've often found there's considerable trial and error involved with this client :-)
Anyway, I've fixed it well enough to get a test pass when I copied/pasted this into the existing CmdsHashExample.cs in my NRedisStack clone, so I've just copied that back into this PR. I think what the user sees is valid, but we'll see if any further fixing up is required when we eventually submit this to the NRedisStack repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing that. I do have the latest NRedisStack repo in my clients directory and that's what I point Auggie to. I'm not following the bit about doing a dotnet build. Do you mean in the repo itself? Also, I deleted the .Net stuff from VS Code--it kept crashing. ><
Is there anything left to do on this PR? If not, would you mind approving it so I can get it merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think things like HEXPIRE are in StackExchange.Redis rather than NRedisStack, so the intellisense and Augie stuff might not get updated until you rebuild and pull everything in from SE (not 100% sure this is how it works, but seems to solve problems sometimes). Anyway, I can definitely see HashFieldExpire and Augie can suggest it, so presumably I've got some update that you haven't.
Co-authored-by: andy-stark-redis <[email protected]>
|
Hi @andy-stark-redis. Thank you for your review. I've fixed what I could. Please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry - forgot to approve. Anyway, approving now :-)
|
Thank you! |
No description provided.