feat: add custom label support in metric collector - #2849
Closed
AnkitChahar wants to merge 10 commits into
Closed
AnkitChahar wants to merge 10 commits into
AnkitChahar wants to merge 10 commits into
Conversation
AnkitChahar
changed the title
Author
|
@ofekshenawa possible for you to review this? |
Collaborator
|
Hey @AnkitChahar, is it still relevant? |
Author
Hey, yes as it adds support for custom labels in the prom collector |
Member
|
Hello @AnkitChahar , Please document you change and if possible write tests for the added code. |
|
This pull request has been automatically marked as stale due to inactivity. |
|
This pull request has been automatically closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current collector implementation does not have support for custom labels
Added support for the same