fix: improve exponential backoff calculation #3437
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the default
MinRetryBackoff
of 8 ms, the previous implementation for calculating the backoff duration was this:The average delays show this isn't really exponential:
This is actually linear growth with exponential jitter range:
As described in
https://aws.amazon.com/ko/blogs/architecture/exponential-backoff-and-jitter/, we want:
Note that even with this change, Redis Cluster may still not have enough breathing room for cluster discovery.
MaxRetries
,MinRetryBackoff
, andMaxRetryBackoff
likely still need to be tweaked.Relates to #2046