Skip to content

[automatic failover] Fix misleading timing information for AA scenario test #4303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 9, 2025
+11 −4
Merged

[automatic failover] Fix misleading timing information for AA scenario test #4303

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5f00576
[automatic failover] Replace EchoStrategy with PingStrategy (#4313)
atakavci Oct 9, 2025
4a48573
[automatic failover] Remove UnifiedJedis experimental constructor acc…
ggivo Oct 9, 2025
74002e7
Squashed commit of the following:
atakavci Oct 9, 2025
c52a64d
Merge branch 'master' into feature/automatic-failover-4
atakavci Oct 9, 2025
b3f0691
- fix timing info
atakavci Oct 8, 2025
35e54c7
empty commit
atakavci Oct 8, 2025
47be453
format
atakavci Oct 9, 2025
0f936a6
Merge branch 'master' into ali/aa-scenario_test
atakavci Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/test/java/redis/clients/jedis/scenario/ActiveActiveFailoverIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ public void accept(DatabaseSwitchEvent e) {
AtomicLong retryingThreadsCounter = new AtomicLong(0);
AtomicLong failedCommandsAfterFailover = new AtomicLong(0);
AtomicReference<Instant> lastFailedCommandAt = new AtomicReference<>();
Endpoint primaryEndpoint = client.getActiveDatabaseEndpoint();

// Start thread that imitates an application that uses the client
MultiThreadedFakeApp fakeApp = new MultiThreadedFakeApp(client, (UnifiedJedis c) -> {
Expand All @@ -130,13 +131,15 @@ public void accept(DatabaseSwitchEvent e) {
int maxTries = 500;
int retryingDelay = 5;
while (true) {
boolean attemptToExecuteOnFailedCluster = true;
try {
Map<String, String> executionInfo = new HashMap<String, String>() {
{
put("threadId", String.valueOf(threadId));
put("cluster", reporter.getCurrentClusterName());
}
};
attemptToExecuteOnFailedCluster = client.getActiveDatabaseEndpoint() == primaryEndpoint;
client.xadd("execution_log", StreamEntryID.NEW_ENTRY, executionInfo);
executedCommands.incrementAndGet();

Expand All @@ -148,7 +151,8 @@ public void accept(DatabaseSwitchEvent e) {
break;
} catch (JedisConnectionException e) {

if (reporter.failoverHappened) {
if (reporter.failoverHappened && !reporter.failbackHappened
&& attemptToExecuteOnFailedCluster) {
failedCommandsAfterFailover.incrementAndGet();
lastFailedCommandAt.set(Instant.now());
}
Expand Down Expand Up @@ -219,9 +223,12 @@ public void accept(DatabaseSwitchEvent e) {
log.info("Failback happened at: {}", reporter.failbackAt);
log.info("Last failed command at: {}", lastFailedCommandAt.get());
log.info("Failed commands after failover: {}", failedCommandsAfterFailover.get());
Duration fullFailoverTime = Duration.between(reporter.failoverAt, lastFailedCommandAt.get());
log.info("Full failover time: {} s", fullFailoverTime.getSeconds());

if (lastFailedCommandAt.get() == null) {
log.info("No failed commands after failover!");
} else {
Duration fullFailoverTime = Duration.between(reporter.failoverAt, lastFailedCommandAt.get());
log.info("Full failover time: {} s", fullFailoverTime.getSeconds());
}
assertEquals(0, pool1.getNumActive());
assertTrue(fakeApp.capturedExceptions().isEmpty());
assertTrue(reporter.failoverHappened);
Expand Down
Loading