-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Hitless handshake #3735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hitless handshake #3735
Conversation
… tests for maintenance_events.py file
…tion pool - this should be a separate PR
… Refactored the maintenance events tests not to be multithreaded - we don't need it for those tests.
…ot processed in in Moving state. Tests are updated
…ply them during connect
Signed-off-by: Elena Kolevska <[email protected]> Cleanup Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
…isting ones more generic
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
8d7cc00
to
10ded34
Compare
* Typos in commands.py * Correct URL in vectorset commands.py
…onPolicyInterface(redis#3732)
…#3512) * Fix async safety when Redis client is used as an async context manager When the async Redis client is used as an async context manager and called from different corotuines, one coroutine can exit, shutting down the client's connection pool, while another coroutine is attempting to use a connection. This results in a connection error, such as: redis.exceptions.ConnectionError: Connection closed by server. Additional locking in `ConnectionPool` resolves the problem but introduces extreme latency due to the locking. Instead, this PR implements a shielded counter that increments as callers enter the async context manager and decrements when they exit. The client then closes its connection pool only after all active contexts exit. Performance is on par with use of the client without a context manager.
Signed-off-by: Elena Kolevska <[email protected]>
…over_events_handling
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements hitless handshake functionality for Redis maintenance events by adding a handshake process and updating message formats to include sequence IDs. The changes enable clients to negotiate maintenance notification preferences with the server during connection establishment.
- Adds endpoint type detection and validation for CLIENT MAINT_NOTIFICATIONS command
- Updates server maintenance message format to include sequence ID as the first parameter
- Changes default maintenance events configuration from disabled to enabled
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
redis/maintenance_events.py |
Adds EndpointType class and endpoint detection logic to MaintenanceEventsConfig for handshake negotiation |
redis/connection.py |
Implements CLIENT MAINT_NOTIFICATIONS handshake during connection establishment and adds IP resolution method |
redis/_parsers/base.py |
Updates message parsing to handle new format with sequence ID as first parameter |
tests/test_maintenance_events.py |
Adds comprehensive tests for endpoint type detection and validation |
tests/test_maintenance_events_handling.py |
Updates mock server responses to match new message format with sequence ID |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
||
logger = logging.getLogger(__name__) | ||
logger.warning(f"Failed to enable maintenance notifications: {e}") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The broad exception handling catches all exceptions during the handshake process. Consider being more specific about which exceptions to handle and potentially re-raise authentication or connection errors that shouldn't be silently ignored.
except (AuthenticationError, ConnectionError) as e: | |
# Re-raise critical connection/authentication errors | |
raise | |
except ResponseError as e: | |
# Log warning but don't fail the connection for expected server response errors | |
import logging | |
logger = logging.getLogger(__name__) | |
logger.warning(f"Failed to enable maintenance notifications: {e}") |
Copilot uses AI. Check for mistakes.
193219d
into
redis:feat/hitless-upgrade-sync-standalone
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change