Fix(react-router): Correct href() to processes routes that have an extension after the parameter or are a single optional parameter

[ngbrown]

Fixes #13795 and supersedes #13613

It is possible to have routes with an extension (/:id.txt) or with a single optional parameter (/:lang?). href() did not handle those cases correctly.

This fixes that with an implementation of href() that more closely resembles how compilePath() handles the path.

For a demonstration of the issue, see the bug-report-test.ts in #13795 or this example project.

[changeset-bot]

🦋 Changeset detected

Latest commit: 4997ef8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
react-router	Patch
@react-router/architect	Patch
@react-router/cloudflare	Patch
@react-router/dev	Patch
react-router-dom	Patch
@react-router/express	Patch
@react-router/node	Patch
@react-router/serve	Patch
@react-router/fs-routes	Patch
@react-router/remix-routes-option-adapter	Patch
create-react-router	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[ngbrown]

@pcattori Do you have feedback for how I implemented this fix to href()?

[ngbrown]

@timdorr and @pcattori, is this something that can be reviewed soon? If @pcattori is too busy, maybe someone else can review it?

[github-actions]

🤖 Hello there,

We just published version 7.9.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 7.9.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!