Support PostgreSQL 18 #13
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the create_postgres MCP tool’s PostgreSQL version configuration to allow creating newer Render Postgres databases by expanding the accepted version range and changing the default.
Changes:
- Increased minimum allowed Postgres version from 12 → 13.
- Increased maximum allowed Postgres version from 16 → 18.
- Updated the tool schema default Postgres version from 16 → 18.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -119,9 +119,9 @@ func createPostgres(postgresRepo *Repo) server.ServerTool { | |||
| ), | |||
| mcp.WithNumber("version", | |||
| mcp.Description("PostgreSQL version to use (e.g., 14, 15)"), | |||
There was a problem hiding this comment.
The parameter description still uses examples “(e.g., 14, 15)” even though the tool now defaults to 18 and allows up to 18. Update the description to include 18 and/or explicitly state the supported range (13–18) so users aren’t misled by the examples.
| mcp.Description("PostgreSQL version to use (e.g., 14, 15)"), | |
| mcp.Description("PostgreSQL version to use (13–18, e.g., 14, 15, 18)"), |
| mcp.Min(13), | ||
| mcp.Max(18), | ||
| mcp.DefaultNumber(18), |
There was a problem hiding this comment.
This change advertises/supports PostgreSQL 18 at the MCP tool layer, but the generated API types still only define PostgresVersion enum constants up to 16 (see pkg/client/types_gen.go). Consider regenerating/updating the API client schema (or otherwise aligning types/docs) so the codebase’s declared supported versions aren’t inconsistent.
| mcp.WithNumber("version", | ||
| mcp.Description("PostgreSQL version to use (e.g., 14, 15)"), | ||
| mcp.Min(12), | ||
| mcp.Max(16), | ||
| mcp.DefaultNumber(16), | ||
| mcp.Min(13), | ||
| mcp.Max(18), | ||
| mcp.DefaultNumber(18), |
There was a problem hiding this comment.
The Postgres tool tests currently assert the schema default for plan, but not for the version field. Since this PR changes min/max/default for version, add/extend tests to cover the version schema defaults/constraints (and ideally that a provided version is passed through to the API request) to prevent regressions.
|
@greptile |
|
@claude review |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
2 participants
Allow Render MCP-Server to create PostgreSQL 18 databases