Skip to content

Add Flatpak installation support - #149

Merged
lleyton merged 4 commits into
replugged-org:mainfrom
V3L0C1T13S:main
Aug 26, 2022
Merged

lleyton merged 4 commits into
replugged-org:mainfrom
V3L0C1T13S:main

Conversation

@V3L0C1T13S

Copy link
Copy Markdown
Contributor

Adds support for Flatpak installations of Discord and Discord Canary.

@lleyton lleyton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could run the flatpak override command in the installer?

@Vendicated

This comment was marked as spam.

@lleyton

lleyton commented Aug 25, 2022

Copy link
Copy Markdown
Contributor

Fair enough. On the point of updating Replugged and plugins, I would be open to including that shell script as an npm script, a temporary stopgap. I think a better long-term solution is to:

  1. Ship replugged as a Flatpak and install the Git binary, see Luna's comment on this.
  2. Eventually remove the dependency on the Git binary, whether that's through WASM or isomorphic-git.

@Vendicated

This comment was marked as spam.

@lleyton

lleyton commented Aug 25, 2022

Copy link
Copy Markdown
Contributor

it's possible that we could have a bot to bump the Discord version, if that's the main burden with maintaining a Replugged flatpak

@V3L0C1T13S
V3L0C1T13S requested a review from lleyton August 25, 2022 18:00

@lleyton lleyton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! Could we add a message of how to update powercord/plugins (until we get something more proper?) Maybe just reference Ven's script?

@V3L0C1T13S
V3L0C1T13S requested a review from lleyton August 26, 2022 02:55

@lleyton lleyton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lleyton
lleyton merged commit be8916e into replugged-org:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants