-
Notifications
You must be signed in to change notification settings - Fork 824
feat(demo): use Tailwind v4 in notion-magic-link.tsx #2488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: chore/basic-setup
Are you sure you want to change the base?
feat(demo): use Tailwind v4 in notion-magic-link.tsx #2488
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
475bd84
to
36433e3
Compare
36433e3
to
298ae22
Compare
dd1eb2c
to
6e7526e
Compare
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
6e7526e
to
0a76254
Compare
0a76254
to
3456597
Compare
c0326ed
to
a04f629
Compare
3456597
to
226c97a
Compare
9b37bb9
to
147568d
Compare
8645b11
to
af781e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 3 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="apps/demo/emails/magic-links/notion-magic-link.tsx">
<violation number="1" location="apps/demo/emails/magic-links/notion-magic-link.tsx:45">
`w-9/10` isn’t generated by the email Tailwind config, so the login code block loses its intended 90% width. Please switch to an arbitrary value utility.</violation>
<violation number="2" location="apps/demo/emails/magic-links/notion-magic-link.tsx:51">
`mb-9.5` isn’t part of the Tailwind preset you’re using, so the helper text loses its 38px bottom margin. Use an arbitrary spacing value to keep the layout consistent.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
<Text className="text-[#ababab] text-sm mt-3.5 mb-4"> | ||
If you didn't try to login, you can safely ignore this email. | ||
</Text> | ||
<Text className="text-[#ababab] text-sm mt-3.5 mb-9.5"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mb-9.5
isn’t part of the Tailwind preset you’re using, so the helper text loses its 38px bottom margin. Use an arbitrary spacing value to keep the layout consistent.
Prompt for AI agents
Address the following comment on apps/demo/emails/magic-links/notion-magic-link.tsx at line 51:
<comment>`mb-9.5` isn’t part of the Tailwind preset you’re using, so the helper text loses its 38px bottom margin. Use an arbitrary spacing value to keep the layout consistent.</comment>
<file context>
@@ -23,66 +25,54 @@ export const NotionMagicLinkEmail = ({
+ <Text className="text-[#ababab] text-sm mt-3.5 mb-4">
+ If you didn&apos;t try to login, you can safely ignore this email.
+ </Text>
+ <Text className="text-[#ababab] text-sm mt-3.5 mb-9.5">
+ Hint: You can set a permanent password in Settings & members → My
+ account.
</file context>
<Text className="text-[#ababab] text-sm mt-3.5 mb-9.5"> | |
<Text className="text-[#ababab] text-sm mt-3.5 mb-[38px]"> |
<Text className="text-[#333] text-sm my-6 mb-3.5"> | ||
Or, copy and paste this temporary login code: | ||
</Text> | ||
<code className="inline-block py-4 px-[4.5%] w-9/10 bg-[#f4f4f4] rounded-md border border-solid border-[#eee] text-[#333]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w-9/10
isn’t generated by the email Tailwind config, so the login code block loses its intended 90% width. Please switch to an arbitrary value utility.
Prompt for AI agents
Address the following comment on apps/demo/emails/magic-links/notion-magic-link.tsx at line 45:
<comment>`w-9/10` isn’t generated by the email Tailwind config, so the login code block loses its intended 90% width. Please switch to an arbitrary value utility.</comment>
<file context>
@@ -23,66 +25,54 @@ export const NotionMagicLinkEmail = ({
+ <Text className="text-[#333] text-sm my-6 mb-3.5">
+ Or, copy and paste this temporary login code:
+ </Text>
+ <code className="inline-block py-4 px-[4.5%] w-9/10 bg-[#f4f4f4] rounded-md border border-solid border-[#eee] text-[#333]">
+ {loginCode}
+ </code>
</file context>
e30c236
to
e55a1fe
Compare
Summary by cubic
Refactored the Notion magic link demo email to use Tailwind classes via @react-email/tailwind, removing inline styles for simpler styling and easier maintenance. Updated the demo to the Tailwind-compatible @react-email/components package.
Refactors
Dependencies