Exclude readonly filesystems from disk space graph

[septatrix]

squashfs and erofs always have a fixed size and are generally 100% filled up. Showing them makes little sense and makes the graph harder to digest.

Alternatively, instead of hiding them completely they could have an override to hide the fill. This way the graphs are easier to digest but one still has them inside the graph.

[rfmoz]

Hi @septatrix,

Each of us has different requirements, so please use the dashboard as a starting point and adapt it to your environment.

Thanks,

[septatrix]

I understand that the dashboard are to be used as a starting point though I cannot think of a single reason why one would want to monitor read-only filesystems for space exhaustion. The sane default thus seems to be to hide them, and those who really want to watch them (for whatever obscure reason) could still show them. The most important thing should always be to have sensible defaults...

[rfmoz]

node_exporter’s filesystem collector ignores certain filesystem types by default:

--collector.filesystem.ignored-fs-types="^(sys|proc|autofs|tmpfs|devtmpfs|devfs|iso9660|overlay)$"

It can be changed easily to:

--collector.filesystem.ignored-fs-types="^(sys|proc|autofs|tmpfs|devtmpfs|devfs|iso9660|overlay|squashfs|eros)$"

[septatrix]

I am aware of that and there is even an upstream PR to include erofs in the default exclude list though until that is merged, widely available, and can be trusted upon to be present (especially LTS distros) it's gonna take years. Including it here results in a quicker turnaround and shouldn't hurt anyone

[heitorPB]

Is this still relevant? node_exporter's default ignored filesystem includes eros and squashfs now. See https://github.com/Nemric/node_exporter/blob/master/collector/filesystem_linux.go#L36