fix generator for swagger_model when no property required #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the fix, the generator is assigning null to `required` field, which raises error ``` swagger-ui.js:2362 Uncaught TypeError: Swagger 2.0 does not support null types ([object Object]). See OAI/OpenAPI-Specification#229. ``` This fix will instead not to create a `required` field for the json, as to match the way how swagger_ui has done it, see https://github.com/swagger-api/swagger-ui/blob/master/test/specs/v1.2/petstore/store.json#L113
|
@richhollis can you have a look at this PR fix please :) |
|
@richhollis just to follow up this PR, I am keen to know if the fix is not appropriate, is there something i missed, looking forward to hear from you about your thoughts, thank you |
|
hello @richhollis , just to follow up this PR, is this something else you would want to check/done with this PR? |
|
@richhollis ^...wondering if this PR still valid? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix, the generator is assigning null to
requiredfield,which raises error
This fix will instead not to create a
requiredfield for the json, as to match the way how swagger_ui has done it, see https://github.com/swagger-api/swagger-ui/blob/master/test/specs/v1.2/petstore/store.json#L113