-
Notifications
You must be signed in to change notification settings - Fork 74
Move Mavis forward; use Boost::json #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Mavis should compile cleanly with C++20 unless you're using a Clang version older than 16 (this branch has a preliminary fix for that: https://github.com/sparcians/mavis/tree/dev/bdutro/clang-15-std-views-fix). |
|
I think you need to bump the minimum Boost version to 1.78. |
|
@bdutro I moved mavis to the latest for Olympia on my local box and get this compile issue with gcc v13. |
|
@klingaard you need to change this line to enable C++20 support: https://github.com/riscv-software-src/riscv-perf-model/pull/280/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR2 |
Thanks, @bdutro for giving some guidance here! After attending RVI 2025 this year, I heard a few complaints about olympia's conda requirements. I've decided to remove that constraint now that we have some stability on Ubuntu distro solutions in GitHub CI. Will be pushing a new PR that tears this down. 🤞 |
Signed-off-by: Knute Lingaard <[email protected]>
39a854c to
a7e93a3
Compare
|
Trying an experiment -- I rebased this branch onto #281 to see if I can get it pass |
Moved to almost the tip of Mavis. The head of Mavis requires c++23 features (@bdutro) which we might not be ready for yet.
Started to deprecate the use of nlohmann::json and moved to Boost::json. Can't remove it completely as FSL still uses it and we're pointing to a mirror (for now). Put that header in
deprecateddirectory for now.Also cleaned up some header file allocations to improve compile time.