Repository navigation
Conversation
klingaard
self-requested a review
January 21, 2026 14:28
Collaborator
|
Appreciate the submission to the project, but we like to see PRs with more subsistence, bug fixes, enhancements, etc along with syntactical changes. If you are interested in taking on an existing issue or fixing latest compilation issues with newer compilers, etc, that's invaluable! For now, I'm going to close this and expect to see it again from you in a PR that addresses a larger purpose. 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-format identified style violations in core/CPU.cpp. I have applied the fixes using the project's .clang-format configuration. Note: I ran make regress locally. While the main olympia integration tests passed, some unit tests (like Dispatch_test) failed. I verified that these tests fail even on a clean master branch without my changes, so the failures are unrelated to this PR.