Fix several normative rule coverpoint mapping typos - #2340
Merged
Jordan Carlin (jordancarlin) merged 2 commits intoSep 14, 2026
Merged
Conversation
PMPSm.yaml's misaligned-access rule never closed its coverpoint list, so the CTP table rendered the entry with the brace still open. ExceptionsSm.yaml named the covergroup ExceptionsSm and Zfbfmin.yaml named Zfbfmin_fcvt_bf16_s; the generated groups are ExceptionsSm_cg and Zfbfmin_fcvt_bf16_s_cg. Every coverpoint listed on those lines resolves once the suffix is right. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DnYUaYh9RhXvWSgHzGSyay Signed-off-by: David Harris <David_Harris@hmc.edu>
Two more classes of reference that resolve to nothing:
- D, F, Zfh and ZfhD rules spell the frm crosses cp_fs1_edges_frm{,_D,_H} and
cp_fs1_fs2_edges_frm_D. The generator emits these as crosses, so the names
begin with cr_.
- SvZicbo rules name Abit_unset_cbo_s and Dbit_unset_zicbom_s without the cp_
prefix the covergroup declares.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DnYUaYh9RhXvWSgHzGSyay
Signed-off-by: David Harris <David_Harris@hmc.edu>
github-actions
Bot
added
status: needs-review
Jordan Carlin (jordancarlin)
approved these changes
Sep 14, 2026
Jordan Carlin (jordancarlin)
changed the title
github-actions
Bot
added
status: approved
Jordan Carlin (jordancarlin)
pushed a commit
to jordancarlin/riscv-arch-test
that referenced
this pull request
Sep 16, 2026
**Syntax**
- `PMPSm.yaml:10` — the misaligned-access rule's coverpoint list was
never closed (`… cp_tor_doubleregionfail",`
with no `}`).
**Covergroup names**
- `ExceptionsSm.yaml:194` named `ExceptionsSm`; the generated group is
`ExceptionsSm_cg`.
- `Zfbfmin.yaml:6,10` named `Zfbfmin_fcvt_bf16_s`; the generated group
is `Zfbfmin_fcvt_bf16_s_cg`.
**Coverpoint names**
- `D`, `F`, `Zfh` and `ZfhD` spell the frm crosses
`cp_fs1_edges_frm{,_D,_H}` and `cp_fs1_fs2_edges_frm_D`.
The generator emits these as crosses, so the names begin with `cr_`. (17
references.)
- `SvZicbo` names `Abit_unset_cbo_s` and `Dbit_unset_zicbom_s` without
the `cp_` prefix the covergroup
declares. (4 references.)
---------
Signed-off-by: David Harris <David_Harris@hmc.edu>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syntax
PMPSm.yaml:10— the misaligned-access rule's coverpoint list was never closed (… cp_tor_doubleregionfail",with no
}).Covergroup names
ExceptionsSm.yaml:194namedExceptionsSm; the generated group isExceptionsSm_cg.Zfbfmin.yaml:6,10namedZfbfmin_fcvt_bf16_s; the generated group isZfbfmin_fcvt_bf16_s_cg.Coverpoint names
D,F,ZfhandZfhDspell the frm crossescp_fs1_edges_frm{,_D,_H}andcp_fs1_fs2_edges_frm_D.The generator emits these as crosses, so the names begin with
cr_. (17 references.)SvZicbonamesAbit_unset_cbo_sandDbit_unset_zicbom_swithout thecp_prefix the covergroupdeclares. (4 references.)