-
Notifications
You must be signed in to change notification settings - Fork 700
refactor(meta): maintain subscription information in job info #23529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
31f285b to
10165ff
Compare
yezizp2012
approved these changes
Oct 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2036784 to
a3248fb
Compare
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously in global barrier worker, we maintain the subscription information in
InflightSubscriptionInfoseparately to each streaming job. However, each subscription must be associated to a streaming job (table or MV), so it's more intuitive to maintain the subscription information insideInflightStreamingJobInfo.Previously, the CN local barrier worker maintains a copy of the global subscription information and will clone and pass the global copy to each newly spawned actors for their MV executor to check whether there is initially subscription on the MV. After this PR, the CN local barrier worker won't maintain these information anymore. Instead, the information of initial subscription of an actor will be carried in the
BuildActorInfoof each actor. The newly added field inBuildActorInfowill be filled in according to the subscription information maintained in theInflightStreamingJobInfothat the actor belongs to.Checklist
Documentation
Release note