Skip to content

Conversation

@wenym1
Copy link
Contributor

@wenym1 wenym1 commented Oct 21, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously in global barrier worker, we maintain the subscription information in InflightSubscriptionInfo separately to each streaming job. However, each subscription must be associated to a streaming job (table or MV), so it's more intuitive to maintain the subscription information inside InflightStreamingJobInfo.

Previously, the CN local barrier worker maintains a copy of the global subscription information and will clone and pass the global copy to each newly spawned actors for their MV executor to check whether there is initially subscription on the MV. After this PR, the CN local barrier worker won't maintain these information anymore. Instead, the information of initial subscription of an actor will be carried in the BuildActorInfo of each actor. The newly added field in BuildActorInfo will be filled in according to the subscription information maintained in the InflightStreamingJobInfo that the actor belongs to.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@wenym1 wenym1 marked this pull request as ready for review October 21, 2025 11:22
Copy link
Contributor Author

wenym1 commented Oct 21, 2025

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenym1 wenym1 force-pushed the yiming/maintain-subscription-only-in-meta branch from 2036784 to a3248fb Compare October 27, 2025 10:31
@wenym1 wenym1 added this pull request to the merge queue Oct 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2025
@wenym1 wenym1 added this pull request to the merge queue Oct 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2025
@wenym1 wenym1 added this pull request to the merge queue Oct 28, 2025
Merged via the queue into main with commit d201911 Oct 28, 2025
44 of 46 checks passed
@wenym1 wenym1 deleted the yiming/maintain-subscription-only-in-meta branch October 28, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants